Feat/service tasks #2277
Open
Feat/service tasks #2277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughSeveral new documentation files were added to Altinn Studio, focusing on the concepts of business processes, process tasks, and system tasks (service tasks) including guides for implementing and configuring them, with examples for PDF generation and eFormidling. Additionally, minor metadata updates were made to existing process-related documentation in Norwegian Bokmål and English. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Altinn Studio Docs
participant Altinn App
participant BPMN Process Engine
Developer->>Altinn Studio Docs: Reads about process and system tasks
Developer->>Altinn App: Implements custom IServiceTask (optional)
Developer->>BPMN Process Engine: Adds serviceTask node in process.bpmn
BPMN Process Engine->>Altinn App: Executes service task (PDF, eFormidling, custom)
Altinn App-->>BPMN Process Engine: Returns task result, advances process
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (8)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (9)
content/altinn-studio/reference/process/tasks/_index.nb.md (1)
2-3: Beskrivelsen trenger en handlingsform for å skille seg fra tittelenBegge feltene gjentar de samme to ordene; vurder å gjøre beskrivelsen mer verb-orientert slik at den tydelig forklarer formålet med siden.
-title: Prosessoppgaver -description: Definere prosessoppgaver +title: Prosessoppgaver +description: Slik definerer du prosessoppgavercontent/altinn-studio/reference/process/_index.en.md (1)
2-3: Polish the English descriptionMore idiomatic wording makes the sentence read smoother.
-description: The application has a process that can be modified according to needs +description: The application includes a process that can be tailored to specific needscontent/altinn-studio/guides/development/service-tasks/intro.nb.md (2)
9-9: Manglende verb i eksempellisten-Eksempler på standard systemoppgaver PDF-generering og eFormidling. +Eksempler på standard systemoppgaver er PDF-generering og eFormidling.
11-11: Pronomen- og ordvalg-Tjenesteeiere kan implementere sine egne systemoppgaver og legge de som steg i appens prosess. +Tjenesteeiere kan implementere egne systemoppgaver og legge dem inn som steg i appens prosess.content/altinn-studio/guides/development/service-tasks/_index.nb.md (2)
2-2: Fjern overflødig mellomrom i tittelenDet henger et ekstra blanktegn til slutt.
-title: Hvordan konfigurere systemoppgaver i din Altinn-app +title: Hvordan konfigurere systemoppgaver i din Altinn-app
5-5: Bruk flertall i taggen for konsistens-tags: [systemoppgave, service task] +tags: [systemoppgaver, service task]content/altinn-studio/guides/development/service-tasks/eformidling/_index.nb.md (1)
7-11: Correct misspellings and clarify wording in intro & warning blockSeveral typos weaken the credibility of the guide:
eFormilding→eFormidlinggrenerelle→generellefunksjonalitenen→funksjonaliteten-En systemoppgave for å sende instansdata via eFormilding følger med appen som standard, og kan legges til som et steg i prosessen for å tas i bruk. +En systemoppgave for å sende instansdata via eFormidling følger med appen som standard og kan legges til som et steg i prosessen for å tas i bruk. -Tidligere lå ikke denne funksjonaliteten i en systemoppgave, men var bakt inn i den grenerelle koden for å endre prosesssteg. Dersom appen din ble satt opp før versjon 8.7, så bør du deaktivere funksjonalitenen som kjøres utenfor prosessdefinisjonen. +Tidligere lå ikke denne funksjonaliteten i en systemoppgave, men var bakt inn i den generelle koden som håndterer prosesssteg. Dersom appen din ble satt opp før versjon 8.7, bør du deaktivere funksjonaliteten som kjøres utenfor prosessdefinisjonen.content/altinn-studio/concepts/process/_index.nb.md (1)
18-20: Polish wording around upcoming breaking changesThe sentence is a bit clunky and mixes tenses. A more natural phrasing in Bokmål:
-Det er mulig å opprette sine egne prosessoppgaver, men det er sannsynlig at det kommer relativt store breaking changes på interfacet i neste major versjon (9.0). +Det er mulig å opprette egne prosessoppgaver, men det er sannsynlig at interfacet vil endres betydelig (breaking changes) i neste hovedversjon (9.0).content/altinn-studio/guides/development/service-tasks/pdf/_index.nb.md (1)
10-13: Fix repeated typos in warning blockSame misspellings as in the eFormidling guide:
-Tidligere lå ikke denne funksjonaliteten i en systemoppgave, men var bakt inn i den grenerelle koden for å endre prosesssteg. Dersom appen din ble satt opp før versjon 8.7, så bør du deaktivere funksjonalitenen som kjøres utenfor prosessdefinisjonen. +Tidligere lå ikke denne funksjonaliteten i en systemoppgave, men var bakt inn i den generelle koden som håndterer prosesssteg. Dersom appen din ble satt opp før versjon 8.7, bør du deaktivere funksjonaliteten som kjøres utenfor prosessdefinisjonen.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
content/altinn-studio/guides/development/service-tasks/example-service-task-process.pngis excluded by!**/*.png
📒 Files selected for processing (9)
content/altinn-studio/concepts/process/_index.nb.md(1 hunks)content/altinn-studio/guides/development/service-tasks/_index.nb.md(1 hunks)content/altinn-studio/guides/development/service-tasks/custom/_index.nb.md(1 hunks)content/altinn-studio/guides/development/service-tasks/eformidling/_index.nb.md(1 hunks)content/altinn-studio/guides/development/service-tasks/intro.nb.md(1 hunks)content/altinn-studio/guides/development/service-tasks/pdf/_index.nb.md(1 hunks)content/altinn-studio/reference/process/_index.en.md(1 hunks)content/altinn-studio/reference/process/_index.nb.md(1 hunks)content/altinn-studio/reference/process/tasks/_index.nb.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
`**/*.nb.md`: Check for Norwegian Bokmål (nb-NO) grammar and spelling with extra care. Pay special attention to specialized terminology and Norwegian-specific words.
**/*.nb.md: Check for Norwegian Bokmål (nb-NO) grammar and spelling with extra care. Pay special attention to specialized terminology and Norwegian-specific words.
⚙️ Source: CodeRabbit Configuration File
List of files the instruction was applied to:
content/altinn-studio/reference/process/tasks/_index.nb.mdcontent/altinn-studio/reference/process/_index.nb.mdcontent/altinn-studio/guides/development/service-tasks/intro.nb.mdcontent/altinn-studio/guides/development/service-tasks/_index.nb.mdcontent/altinn-studio/guides/development/service-tasks/pdf/_index.nb.mdcontent/altinn-studio/guides/development/service-tasks/custom/_index.nb.mdcontent/altinn-studio/guides/development/service-tasks/eformidling/_index.nb.mdcontent/altinn-studio/concepts/process/_index.nb.md
`content/**/*`: Check for links, markdown formatting, headings, grammar, and spelling in multiple languages (en-US, nb-NO, nn-NO).
content/**/*: Check for links, markdown formatting, headings, grammar, and spelling in multiple languages (en-US, nb-NO, nn-NO).
⚙️ Source: CodeRabbit Configuration File
List of files the instruction was applied to:
content/altinn-studio/reference/process/tasks/_index.nb.mdcontent/altinn-studio/reference/process/_index.nb.mdcontent/altinn-studio/reference/process/_index.en.mdcontent/altinn-studio/guides/development/service-tasks/intro.nb.mdcontent/altinn-studio/guides/development/service-tasks/_index.nb.mdcontent/altinn-studio/guides/development/service-tasks/pdf/_index.nb.mdcontent/altinn-studio/guides/development/service-tasks/custom/_index.nb.mdcontent/altinn-studio/guides/development/service-tasks/eformidling/_index.nb.mdcontent/altinn-studio/concepts/process/_index.nb.md
🧠 Learnings (7)
📓 Common learnings
Learnt from: olemartinorg
PR: Altinn/altinn-studio-docs#2134
File: content/altinn-studio/reference/ux/components/Cards/_index.en.md:20-23
Timestamp: 2025-04-24T12:27:04.998Z
Learning: For the Altinn Studio Docs repository, component links in documentation (like ../image, ../audio, ../video) do not need to use PascalCase (../Image, ../Audio, ../Video) even if they differ from the actual directory case, as the platform likely handles case-insensitivity in path resolution.
Learnt from: mSunberg
PR: Altinn/altinn-studio-docs#0
File: :0-0
Timestamp: 2025-04-04T08:22:36.805Z
Learning: When reviewing Norwegian content (files with .nb.md or .nn.md extensions), carefully check for spelling and grammar issues, particularly watching for changes to specialized terminology like "Digitaliseringsrundskrivet" and Norwegian-specific words.
content/altinn-studio/reference/process/tasks/_index.nb.md (1)
Learnt from: mSunberg
PR: Altinn/altinn-studio-docs#0
File: :0-0
Timestamp: 2025-04-04T08:22:36.805Z
Learning: When reviewing Norwegian content (files with .nb.md or .nn.md extensions), carefully check for spelling and grammar issues, particularly watching for changes to specialized terminology like "Digitaliseringsrundskrivet" and Norwegian-specific words.
content/altinn-studio/reference/process/_index.nb.md (1)
Learnt from: mSunberg
PR: Altinn/altinn-studio-docs#0
File: :0-0
Timestamp: 2025-04-04T08:22:36.805Z
Learning: When reviewing Norwegian content (files with .nb.md or .nn.md extensions), carefully check for spelling and grammar issues, particularly watching for changes to specialized terminology like "Digitaliseringsrundskrivet" and Norwegian-specific words.
content/altinn-studio/guides/development/service-tasks/_index.nb.md (2)
Learnt from: olemartinorg
PR: Altinn/altinn-studio-docs#2134
File: content/altinn-studio/reference/ux/components/Cards/_index.en.md:20-23
Timestamp: 2025-04-24T12:27:04.998Z
Learning: For the Altinn Studio Docs repository, component links in documentation (like ../image, ../audio, ../video) do not need to use PascalCase (../Image, ../Audio, ../Video) even if they differ from the actual directory case, as the platform likely handles case-insensitivity in path resolution.
Learnt from: mSunberg
PR: Altinn/altinn-studio-docs#0
File: :0-0
Timestamp: 2025-04-04T08:22:36.805Z
Learning: When reviewing Norwegian content (files with .nb.md or .nn.md extensions), carefully check for spelling and grammar issues, particularly watching for changes to specialized terminology like "Digitaliseringsrundskrivet" and Norwegian-specific words.
content/altinn-studio/guides/development/service-tasks/pdf/_index.nb.md (1)
Learnt from: olemartinorg
PR: Altinn/altinn-studio-docs#2134
File: content/altinn-studio/reference/ux/components/Cards/_index.en.md:20-23
Timestamp: 2025-04-24T12:27:04.998Z
Learning: For the Altinn Studio Docs repository, component links in documentation (like ../image, ../audio, ../video) do not need to use PascalCase (../Image, ../Audio, ../Video) even if they differ from the actual directory case, as the platform likely handles case-insensitivity in path resolution.
content/altinn-studio/guides/development/service-tasks/eformidling/_index.nb.md (2)
Learnt from: olemartinorg
PR: Altinn/altinn-studio-docs#2134
File: content/altinn-studio/reference/ux/components/Cards/_index.en.md:20-23
Timestamp: 2025-04-24T12:27:04.998Z
Learning: For the Altinn Studio Docs repository, component links in documentation (like ../image, ../audio, ../video) do not need to use PascalCase (../Image, ../Audio, ../Video) even if they differ from the actual directory case, as the platform likely handles case-insensitivity in path resolution.
Learnt from: mSunberg
PR: Altinn/altinn-studio-docs#0
File: :0-0
Timestamp: 2025-04-04T08:22:36.805Z
Learning: When reviewing Norwegian content (files with .nb.md or .nn.md extensions), carefully check for spelling and grammar issues, particularly watching for changes to specialized terminology like "Digitaliseringsrundskrivet" and Norwegian-specific words.
content/altinn-studio/concepts/process/_index.nb.md (1)
Learnt from: olemartinorg
PR: Altinn/altinn-studio-docs#2134
File: content/altinn-studio/reference/ux/components/Cards/_index.en.md:20-23
Timestamp: 2025-04-24T12:27:04.998Z
Learning: For the Altinn Studio Docs repository, component links in documentation (like ../image, ../audio, ../video) do not need to use PascalCase (../Image, ../Audio, ../Video) even if they differ from the actual directory case, as the platform likely handles case-insensitivity in path resolution.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
content/altinn-studio/reference/process/_index.nb.md (1)
2-3: Metadata ser god ut – ingen videre kommentarer
content/altinn-studio/guides/development/service-tasks/intro.nb.md
Outdated
Show resolved
Hide resolved
content/altinn-studio/guides/development/service-tasks/_index.nb.md
Outdated
Show resolved
Hide resolved
Comment on lines
+1
to
+6
| --- | ||
| title: Egendefinert | ||
| tags: [altinn-apps, process, bpmn, task, service task, systemoppgave] | ||
| weight: 10 | ||
| alias: | ||
| --- |
There was a problem hiding this comment.
Front-matter key typo breaks Hugo aliases
The front-matter uses alias: instead of the expected aliases: array. Hugo will silently ignore this, so canonical/old URLs won’t redirect.
-alias:
+aliases:
+# legg inn eventuelle gamle URL-stier her, f.eks.
+# - /nb/altinn-studio/guides/development/service-tasks/custom/📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| --- | |
| title: Egendefinert | |
| tags: [altinn-apps, process, bpmn, task, service task, systemoppgave] | |
| weight: 10 | |
| alias: | |
| --- | |
| --- | |
| title: Egendefinert | |
| tags: [altinn-apps, process, bpmn, task, service task, systemoppgave] | |
| weight: 10 | |
| aliases: | |
| # legg inn eventuelle gamle URL-stier her, f.eks. | |
| # - /nb/altinn-studio/guides/development/service-tasks/custom/ | |
| --- |
🤖 Prompt for AI Agents
In content/altinn-studio/guides/development/service-tasks/custom/_index.nb.md at
lines 1 to 6, the front-matter key is incorrectly set as alias: instead of
aliases:. Change the key from alias: to aliases: and make sure it is an array,
even if it contains a single value, to ensure Hugo processes the aliases
correctly for URL redirection.
…nb.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…b.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
bjorntore
force-pushed
the
feat/service-tasks
branch
from
346b145 to
a369df4
Compare
martinothamar
approved these changes
Aug 7, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related app-lib PR: Altinn/app-lib-dotnet#745
Summary by CodeRabbit